Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider adding a CommonJS build output #156

Open
andreas-karlsson opened this issue Jun 3, 2024 · 1 comment
Open

Reconsider adding a CommonJS build output #156

andreas-karlsson opened this issue Jun 3, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@andreas-karlsson
Copy link
Contributor

It's still tricky to make Node execute TS with esm imports.

Feature Suggestion

Add cjs output in the build.

@andreas-karlsson andreas-karlsson added the help wanted Extra attention is needed label Jun 3, 2024
@nicklasl
Copy link
Member

nicklasl commented Jul 3, 2024

For now, the workaround is to use an approach similar to this:

async function main() {
  const { Confidence } = await import("@spotify-confidence/sdk");
  const confidence = Confidence.create({
    ...
  });

  const flagValue = await confidence.getFlag("MyFlag.flag_property", false);
  console.log("Flag value: ", flagValue);
}
main();

and combine it with the following in the tsconfig.json of the project:

"ts-node": {
  "compilerOptions": {
    "module": "ESNext",
    "moduleResolution": "Node"
  }
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants