feat: Telemetry header #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it possible to generate encode methods correctly
nicklasl
force-pushed
the
telemetry-header
branch
3 times, most recently
from
e9f7081
to
ac1590a
Compare
nicklasl
force-pushed
the
telemetry-header
branch
from
ac1590a
to
7892603
Compare
nicklasl
commented
Nov 26, 2024
nicklasl
requested review from
Billlynch,
andreas-karlsson,
fabriziodemaria,
mfranberg,
vahidlazio and
nickybondarenko
as code owners
| @@ -275,6 +297,25 @@ export class CachingFlagResolverClient implements FlagResolverClient { | |||
| } | |||
| } | |||
|
|
|||
| export function withTelemetryData( | |||
| fetchImplementation: (request: Request) => Promise<Response>, | |||
There was a problem hiding this comment.
Hmm.. now that we have these two orthogonal fetch modifiers, maybe it would be nicer to pass a FetchBuilder to this function and the other. It's a little nicer than composing them.. wdyt?
nicklasl
force-pushed
the
telemetry-header
branch
from
aa4741f
to
f51b174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR appends resolve latency telemetry on the header as well as sets the API for adding other type of telemetry.