Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

ffwd version should be added as a tag on a metric #190

Open
dmichel1 opened this issue Feb 27, 2020 · 3 comments
Open

ffwd version should be added as a tag on a metric #190

dmichel1 opened this issue Feb 27, 2020 · 3 comments

Comments

@dmichel1
Copy link
Contributor

dmichel1 commented Feb 27, 2020

That way the version can be monitored when doing a deploy.

@hexedpackets
Copy link
Contributor

Should it be a resource identifier to prevent disappearing metrics in Heroic?

@sjoeboo
Copy link
Contributor

sjoeboo commented Feb 27, 2020

I was actually assuming this would be a what = ffwd-version w/ some value emitted (in the $key = ffwd-java). not some tag appended to everything. That way we can query for that and use say count(what,) groupBy to measure rollouts.

@hexedpackets
Copy link
Contributor

We could measure rollouts that way, but not compare metrics across versions - eg that wouldn't show the UDP issue from #191. So I guess what's our goal with the version tag? Measure rollout progress or watch for performance regressions?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants