Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance savepoint related features and reorganize those routines #84

Closed
elanv opened this issue Aug 25, 2021 · 2 comments · Fixed by #107
Closed

Enhance savepoint related features and reorganize those routines #84

elanv opened this issue Aug 25, 2021 · 2 comments · Fixed by #107

Comments

@elanv
Copy link
Contributor

elanv commented Aug 25, 2021

Currently, savepoint and its related routines are scattered in several places. I was also involved in developing those routines. But I think it would be nice if those were organized more to make this operator easier to maintain and extend. Therefore I had made the PR GoogleCloudPlatform/flink-on-k8s-operator#420.

What do you think about the PR? @regadas
If you agree I will try to rework the PR based on this fork.
@elanv elanv changed the title Organize routines related to the savepoint features. Enhance savepoint related features and reorganize those routines Aug 25, 2021
@regadas
Copy link
Contributor

regadas commented Aug 26, 2021

Hi @elanv I had a quick look to the PR and it looks very interesting! Feel free to make a PR and rebase on this fork; There are quite some changes including the addition of flinkVersion.

@elanv
Copy link
Contributor Author

elanv commented Aug 26, 2021

Thanks for the review. @regadas
It will take some time, but let's proceed.

@numbnut numbnut mentioned this issue Sep 9, 2021
Closed
@elanv elanv mentioned this issue Sep 16, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Elaborate savepoint and update features elanv/flink-on-k8s-operator
2 participants
@regadas @elanv