fix: trigger map update when group selection changes

spraakbanken · Sep 16, 2024 · 1db0c37 · 1db0c37
1 parent b6ae9e2
commit 1db0c37
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/app/scripts/controllers/map_controller.ts b/app/scripts/controllers/map_controller.ts
@@ -93,10 +93,11 @@ angular.module("korpApp").directive("mapCtrl", [
 
                 $scope.toggleMarkerGroup = function (groupName: string) {
                     $scope.markerGroups[groupName].selected = !$scope.markerGroups[groupName].selected
+                    // It is important to replace the array, not modify it, to trigger a watcher in the result-map component.
                     if ($scope.selectedGroups.includes(groupName)) {
-                        $scope.selectedGroups.splice($scope.selectedGroups.indexOf(groupName), 1)
+                        $scope.selectedGroups = $scope.selectedGroups.filter((group) => group != groupName)
                     } else {
-                        $scope.selectedGroups.push(groupName)
+                        $scope.selectedGroups = [...$scope.selectedGroups, groupName]
                     }
                 }