Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word picture: More appropriate message on backend errors #242

Closed
janiemi opened this issue Mar 10, 2022 · 3 comments
Closed

Word picture: More appropriate message on backend errors #242

janiemi opened this issue Mar 10, 2022 · 3 comments
Labels
bug ux "A user interface is like a joke. If you have to explain it, it’s not that good.” – Martin LeBlanc

Comments

@janiemi
Copy link
Contributor

janiemi commented Mar 10, 2022

When the word picture search fails due to a backend error, the word picture result tab shows the message “Could not generate a word picture from you search. Only 'Simple search' on one word or lemgram is supported.”, even if the search is of the kind for which word picture is supported.

This currently happens for this Korp search, which at present causes a GreenletExit in the backend (see spraakbanken/korp-backend#10). Even though that situation might be temporary, I think the frontend should show a different error message.

@majsan majsan added the bug label Mar 15, 2022
@majsan
Copy link
Member

majsan commented Mar 15, 2022

Agree!

@arildm arildm added the ux "A user interface is like a joke. If you have to explain it, it’s not that good.” – Martin LeBlanc label Feb 29, 2024
@arildm
Copy link
Member

arildm commented Jan 16, 2025

I cannot reproduce this now, but backend errors of that kind should be visible now since #97 was fixed.

The given example search instead shows an empty result, and that is because our word picture config doesn't have anything for proper nouns (pm). That should be fixed, but since it doesn't match this issue description I created a new issue for that:

@janiemi Could you check if this is still relevant and add a new example search?

@janiemi
Copy link
Contributor Author

janiemi commented Jan 16, 2025

@arildm, I could not reproduce this any longer, either. Neither could I come up with another word picture search that would result in a backend error. I thus suppose you can close this issue.

@arildm arildm closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ux "A user interface is like a joke. If you have to explain it, it’s not that good.” – Martin LeBlanc
Projects
None yet
Development

No branches or pull requests

3 participants