Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging before search is complete breaks hit count #422

Open
arildm opened this issue Jan 16, 2025 · 0 comments
Open

Paging before search is complete breaks hit count #422

arildm opened this issue Jan 16, 2025 · 0 comments
Labels

Comments

@arildm
Copy link
Member

arildm commented Jan 16, 2025

  1. Make a big search (e.g. enter a common word start like "de" and enable "initial part")
  2. As soon as first page of results is shown, click the next page button ">"
  3. Expected: The hit counter should continue increasing as the progress bar is progressing
  4. Actual: The hit counter remains on the number it was when the next page button was clicked
  5. To verify that the actual hit count is larger, click "Search" again and let it load fully

The makeRequest function in kwic_controller.ts has an isPaging flag. The point is to not reset the hit count while loading when switching page. But it assumes that the current hit count is correct when switching page.

@arildm arildm added the bug label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant