Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to the metadata format #34

Closed
6 tasks done
MartinHammarstedt opened this issue Sep 4, 2024 · 7 comments
Closed
6 tasks done

Make changes to the metadata format #34

MartinHammarstedt opened this issue Sep 4, 2024 · 7 comments
Assignees

Comments

@MartinHammarstedt
Copy link
Member

MartinHammarstedt commented Sep 4, 2024

We will be making a few changes to the metadata format:

referencesother_references (list of strings)
New field: standard_reference (string)

languages.name_enlanguages.name.eng (string)
languages.name_swelanguages.name.swe (string)

@anne17
Copy link
Member

anne17 commented Sep 4, 2024

Just checked the code (parse_yaml.py), looks like no API changes are needed here!

@StaffanMelin
Copy link
Member

StaffanMelin commented Sep 6, 2024

Where can I find:

languages.name_en ⇨ languages.name.eng (string)
languages.name_swe ⇨ languages.name.swe (string)

@MartinHammarstedt ?

Ah, used grep. Eg /corpus/aspacsvsbc.yaml. But I can't find them in the templates, are they deprecated?

@StaffanMelin
Copy link
Member

StaffanMelin commented Sep 6, 2024

create_metashare.py only seems to care about language_codes.

gen_pids.py only cares about language_codes, too.

So for them I will just add the new standard_reference field and change the name of the old references, easy.

@StaffanMelin
Copy link
Member

No changes are need for either create_metashare.py nor gen_pids.py as they don't use the references field. It is a bit strange that references are not exported to the Clarin-repos, isn't it? I can't check the Clarin-repos as it gives errors for all resources...

@StaffanMelin
Copy link
Member

For the web site I have to make changes in the resources import MetadataClient.php, but that is not very time-consuming.

The new standard_reference field is a bit more work in several places, both code and Drupal UI.

@MartinHammarstedt
Copy link
Member Author

Where can I find:

languages.name_en ⇨ languages.name.eng (string)
languages.name_swe ⇨ languages.name.swe (string)

@MartinHammarstedt ?

Ah, used grep. Eg /corpus/aspacsvsbc.yaml. But I can't find them in the templates, are they deprecated?

Not deprecated, probably just forgotten. I'll add them when I make my changes.

@anne17 anne17 removed their assignment Sep 9, 2024
@StaffanMelin
Copy link
Member

Website Drupal issue: https://github.com/spraakbanken/sbwebb-cms/issues/401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants