Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require module namespaces for plugin modules #145

Open
anne17 opened this issue Sep 13, 2021 · 3 comments
Open

Require module namespaces for plugin modules #145

anne17 opened this issue Sep 13, 2021 · 3 comments
Assignees

Comments

@anne17
Copy link
Member

anne17 commented Sep 13, 2021

Our own plugin modules could use the namespace sb or sbx.

@anne17 anne17 added this to the v5.0 milestone Sep 13, 2021
@anne17 anne17 modified the milestones: v5.0, Plugin registry Jun 27, 2022
@anne17
Copy link
Member Author

anne17 commented Jun 27, 2022

It's difficult to enforce obligatory namespaces because module names are Python identifiers (i.e. consist of alphanumeric characters and underscores) which makes it hard to decide on a naming convention. There is no special character that can be used exclusively to divide the namespace from the name.

@kod-kristoff
Copy link
Member

kod-kristoff commented Mar 26, 2024

Does this also apply to annotations?
That is should it be sbx_word_predictions_kb_bert.sbx-word-predictions--kb-bert?

@MartinHammarstedt
Copy link
Member

MartinHammarstedt commented Mar 26, 2024

No, annotations automatically get the plugin name as a prefix (or rather, the part before "." doesn't get removed) in case there is a conflict with another annotation name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants