Skip to content
This repository has been archived by the owner on Aug 10, 2021. It is now read-only.

Fix incorrect sidebar conditions on 2-2-stable branch #156

Open
wants to merge 1 commit into
base: 2-2-stable
Choose a base branch
from

Conversation

paul-at
Copy link

@paul-at paul-at commented Mar 19, 2014

Change 'defined?' check to 'defined and not nil' condition to prevent partials from being called when no valid data is available.

See #155 for fix in master.

…artials being rendered when no valid data is available
@@ -12,9 +12,9 @@
<% end -%>

<% content_for :sidebar do %>
<% if defined? @products && defined? @taxon %>
<% if @products & @taxon %>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not &&?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should be &&

@futhr
Copy link

futhr commented May 3, 2015

See comments in #155

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants