Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue in setting "maximumConcurrentTasks" while installing scdf through helm #6056

Open
VikasMGowda05 opened this issue Nov 8, 2024 · 8 comments
Assignees
Labels
status/need-feedback Calling participant to provide feedback

Comments

@VikasMGowda05
Copy link

Description:
We have seen the SCDF document which says we can set the property maximumConcurrentTasks as below

spring.cloud.dataflow.task.platform..accounts[].deployment.maximumConcurrentTasks`

but while installing the SCDF using helm installation, we need to set this in values.yaml file and information is missing in helm installation document. Could anyone help here?

Release versions:
we are installing "bitnami/spring-cloud-dataflow:2.11.5-debian-12-r2"

Additional context:
Below is our values.yaml file

server:
image:
registry: docker.io
repository: bitnami/spring-cloud-dataflow
tag: 2.11.5-debian-12-r2
digest: ""
pullPolicy: IfNotPresent
pullSecrets: []
debug: false
composedTaskRunner:
image:
registry: docker.io
repository: bitnami/spring-cloud-dataflow-composed-task-runner
tag: 2.11.5-debian-12-r2
digest: ""
configuration:
streamingEnabled: false
batchEnabled: true
accountName: default
trustK8sCerts: false
containerPorts:
http: 8080
jdwp: 5005
replicaCount: 1
updateStrategy:
type: RollingUpdate
startupProbe:
enabled: false
initialDelaySeconds: 120
timeoutSeconds: 1
periodSeconds: 20
failureThreshold: 6
successThreshold: 1
livenessProbe:
enabled: true
initialDelaySeconds: 120
timeoutSeconds: 1
periodSeconds: 20
failureThreshold: 6
successThreshold: 1
readinessProbe:
enabled: true
initialDelaySeconds: 120
timeoutSeconds: 1
periodSeconds: 20
failureThreshold: 6
successThreshold: 1
networkPolicy:
enabled: false
allowExternal: false
allowExternalEgress: false
service:
type: ClusterIP
ports:
http: 8080
ingress:
enabled: true
path: /
pathType: ImplementationSpecific
hostname: "xyz.com"
pdb:
create: false
minAvailable: ""
maxUnavailable: ""
pdb:
create: false
skipper:
enabled: false
rabbitmq:
enabled: false
mariadb:
enabled: false
metrics:
enabled: false
pdb:
create: false
externalDatabase:
host: "{{RDS-endpoint}}.rds.amazonaws.com
driver: com.mysql.cj.jdbc.Driver
dataflow:
url: "{Database url}"
username:
password:

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Nov 8, 2024
@corneil
Copy link
Contributor

corneil commented Nov 8, 2024

@VikasMGowda05
There is no direct property in the values file. Adding the appropriate environmental variable will ensure the value is set for the deployment platform.

server:
  configuration:
    extraEnvVars:
      name: 'SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_KUBERNETES_ACCOUNTS_DEFAULT_MAXIMUM_CONCURRENT_TASKS'
      value: 50

@corneil corneil self-assigned this Nov 8, 2024
@corneil corneil added status/need-feedback Calling participant to provide feedback and removed status/need-triage Team needs to triage and take a first look labels Nov 8, 2024
@corneil
Copy link
Contributor

corneil commented Nov 8, 2024

Description: We have seen the SCDF document which says we can set the property maximumConcurrentTasks as below

spring.cloud.dataflow.task.platform..accounts[].deployment.maximumConcurrentTasks`

but while installing the SCDF using helm installation, we need to set this in values.yaml file and information is missing in helm installation document. Could anyone help here?

Release versions: we are installing "bitnami/spring-cloud-dataflow:2.11.5-debian-12-r2"

Additional context: Below is our values.yaml file

server: image: registry: docker.io repository: bitnami/spring-cloud-dataflow tag: 2.11.5-debian-12-r2 digest: "" pullPolicy: IfNotPresent pullSecrets: [] debug: false composedTaskRunner: image: registry: docker.io repository: bitnami/spring-cloud-dataflow-composed-task-runner tag: 2.11.5-debian-12-r2 digest: "" configuration: streamingEnabled: false batchEnabled: true accountName: default trustK8sCerts: false containerPorts: http: 8080 jdwp: 5005 replicaCount: 1 updateStrategy: type: RollingUpdate startupProbe: enabled: false initialDelaySeconds: 120 timeoutSeconds: 1 periodSeconds: 20 failureThreshold: 6 successThreshold: 1 livenessProbe: enabled: true initialDelaySeconds: 120 timeoutSeconds: 1 periodSeconds: 20 failureThreshold: 6 successThreshold: 1 readinessProbe: enabled: true initialDelaySeconds: 120 timeoutSeconds: 1 periodSeconds: 20 failureThreshold: 6 successThreshold: 1 networkPolicy: enabled: false allowExternal: false allowExternalEgress: false service: type: ClusterIP ports: http: 8080 ingress: enabled: true path: / pathType: ImplementationSpecific hostname: "xyz.com" pdb: create: false minAvailable: "" maxUnavailable: "" pdb: create: false skipper: enabled: false rabbitmq: enabled: false mariadb: enabled: false metrics: enabled: false pdb: create: false externalDatabase: host: "{{RDS-endpoint}}.rds.amazonaws.com driver: com.mysql.cj.jdbc.Driver dataflow: url: "{Database url}" username: password:

You can format a file in issue text by using markdown

@VikasMGowda05
Copy link
Author

VikasMGowda05 commented Nov 8, 2024

@corneil
which one of the below is correct

server:
configuration:
extraEnvVars:
name:' SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_KUBERNETES_ACCOUNTS_DEFAULT_MAXIMUM_CONCURRENT_TASKS'
value: 50

server:
configuration:
extraEnvVars:
name: 'SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_KUBERNETES_ACCOUNTS_DEPLOYMENT_MAXIMUM_CONCURRENT_TASKS'
value: 50

@github-actions github-actions bot added for/team-attention For team attention and removed status/need-feedback Calling participant to provide feedback labels Nov 8, 2024
@cppwfs
Copy link
Contributor

cppwfs commented Nov 8, 2024

It should be the platform name. If you are using default, then it will be default.

@github-actions github-actions bot added status/need-feedback Calling participant to provide feedback and removed for/team-attention For team attention labels Nov 8, 2024
@corneil
Copy link
Contributor

corneil commented Nov 10, 2024

default is the account name. The deployment option is only for Cloud Foundry.

@corneil
Copy link
Contributor

corneil commented Nov 10, 2024

You can add more accounts if you target other namespaces or clusters

@VikasMGowda05
Copy link
Author

VikasMGowda05 commented Dec 10, 2024

Hi @corneil @cppwfs I have tried adding the above as you suggested, I am getting the below error . Could you please help here

server
    Configuration : 
      extraEnvVars:
        name: 'SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_KUBERNETES_ACCOUNTS_DEFAULT_MAXIMUM_CONCURRENT_TASKS'
        value: 100

Error
org.springframework.cloud.dataflow.rest.client.DataFlowClientException: Cannot launch task 'aggregator-job-psp'. The maximum concurrent task executions is at its limit [20].

@github-actions github-actions bot added for/team-attention For team attention and removed status/need-feedback Calling participant to provide feedback labels Dec 10, 2024
@corneil
Copy link
Contributor

corneil commented Dec 13, 2024

@VikasMGowda05 Please try:

server:
  extraEnvVars:
    - name: 'SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_KUBERNETES_ACCOUNTS_DEFAULT_MAXIMUMCONCURRENTTASKS'
      value: 100

@github-actions github-actions bot added status/need-feedback Calling participant to provide feedback and removed for/team-attention For team attention labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-feedback Calling participant to provide feedback
Projects
None yet
Development

No branches or pull requests

3 participants