Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Prometheus Rsocket Proxy milestone (M4) #6069

Open
onobc opened this issue Nov 13, 2024 · 2 comments
Open

Update to latest Prometheus Rsocket Proxy milestone (M4) #6069

onobc opened this issue Nov 13, 2024 · 2 comments
Assignees
Labels
area/dependencies Belongs project dependencies
Milestone

Comments

@onobc
Copy link
Contributor

onobc commented Nov 13, 2024

Let's also do a manual test w/ the proxy after the update to ensure all is well.

@onobc onobc added this to the 3.0.x milestone Nov 13, 2024
@onobc onobc added the area/dependencies Belongs project dependencies label Nov 13, 2024
@onobc onobc self-assigned this Nov 13, 2024
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Nov 13, 2024
This commit updates the Prometheus Rsocket Proxy dependency and Docker images
used in the installers to 2.0.0-M2.

See spring-cloud#6069
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Nov 13, 2024
This commit updates the Prometheus Rsocket Proxy dependency and Docker images
used in the installers to 2.0.0-M2.

See spring-cloud#6069

Signed-off-by: Chris Bono <[email protected]>
onobc added a commit that referenced this issue Nov 14, 2024
This commit updates the Prometheus Rsocket Proxy dependency and Docker images
used in the installers to 2.0.0-M2.

See #6069

Signed-off-by: Chris Bono <[email protected]>
@corneil
Copy link
Contributor

corneil commented Dec 4, 2024

2.0.0-M3 is the latest.
Do we know if 2.0.x is supposed to work with old clients using 1.5.x?

@onobc onobc changed the title Update to Prometheus Proxy M2 Update to latest Prometheus Rsocket Proxy milestone (M3+) Dec 13, 2024
@onobc
Copy link
Contributor Author

onobc commented Dec 13, 2024

2.0.0-M3 is the latest. Do we know if 2.0.x is supposed to work with old clients using 1.5.x?

Great question @corneil . No. Recommendation is to update to the latest client (we are doing this in #6068 )

onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Dec 13, 2024
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient`
with `micrometer.io:micrometer-registry-prometheus`.

Also updates the Prometheus Rsocket version from `2.0.0-M3`
to `2.0.0-SNAPSHOT` as the M3 has a bug. Will update to M4 when available.

See spring-cloud#6068
See spring-cloud#6069
@onobc onobc changed the title Update to latest Prometheus Rsocket Proxy milestone (M3+) Update to latest Prometheus Rsocket Proxy milestone (M4) Dec 13, 2024
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Dec 13, 2024
onobc added a commit to onobc/spring-cloud-dataflow that referenced this issue Dec 13, 2024
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient`
with `micrometer.io:micrometer-registry-prometheus`.

Also updates the Prometheus RSocket version from `2.0.0-M3`
to `2.0.0-M4`.

See spring-cloud#6068
See spring-cloud#6069
onobc added a commit that referenced this issue Dec 19, 2024
Replaces the `micrometer.io:micrometer-registry-prometheus-simpleclient`
with `micrometer.io:micrometer-registry-prometheus`.

Also updates the Prometheus RSocket version from `2.0.0-M3`
to `2.0.0-M4`.

See #6068
See #6069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Belongs project dependencies
Projects
None yet
Development

No branches or pull requests

2 participants