From 9b01949188d24c3327eba0537b1b8fe83f43977b Mon Sep 17 00:00:00 2001
From: erabii <eugen.rabii@gmail.com>
Date: Mon, 2 Oct 2023 17:28:52 +0300
Subject: [PATCH] separate surefire/failsafe directory for report on each
 matrix step (#1463)

---
 .../build-controllers-project/action.yaml     |  4 +++-
 .../action.yaml                               |  3 ++-
 .../action.yaml                               |  3 ++-
 pom.xml                                       | 17 ++++++++++++--
 .../pom.xml                                   | 23 -------------------
 5 files changed, 22 insertions(+), 28 deletions(-)

diff --git a/.github/workflows/composites/build-controllers-project/action.yaml b/.github/workflows/composites/build-controllers-project/action.yaml
index 307451c8f5..dff8da1648 100644
--- a/.github/workflows/composites/build-controllers-project/action.yaml
+++ b/.github/workflows/composites/build-controllers-project/action.yaml
@@ -5,7 +5,9 @@ runs:
   steps:
     - name: build controllers project
       shell: bash
+      env:
+        CURRENT_INDEX: ${{ matrix.current_index }}
       run: |
         cd spring-cloud-kubernetes-controllers
-        .././mvnw -T 1C -U clean install
+        .././mvnw -DCURRENT_INSTANCE=${CURRENT_INDEX} -T 1C -U clean install
         cd ..
diff --git a/.github/workflows/composites/run-and-save-test-times-when-cache-missing/action.yaml b/.github/workflows/composites/run-and-save-test-times-when-cache-missing/action.yaml
index b1d18fef80..d262d89bbd 100644
--- a/.github/workflows/composites/run-and-save-test-times-when-cache-missing/action.yaml
+++ b/.github/workflows/composites/run-and-save-test-times-when-cache-missing/action.yaml
@@ -60,8 +60,9 @@ runs:
         
            ./mvnw -s .settings.xml \
            -DtestsToRun=${TEST_ARG[@]} \
+           -DCURRENT_INSTANCE=${CURRENT_INDEX} \
            -e clean install \
-           -P 'sonar, run-on-github-actions'  -nsu --batch-mode \
+           -P sonar -nsu --batch-mode \
            -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
            -Dhttp.keepAlive=false \
            -Dmaven.wagon.http.pool=false \
diff --git a/.github/workflows/composites/run-and-save-test-times-when-cache-present/action.yaml b/.github/workflows/composites/run-and-save-test-times-when-cache-present/action.yaml
index 7130a907c9..ce2242c3fc 100644
--- a/.github/workflows/composites/run-and-save-test-times-when-cache-present/action.yaml
+++ b/.github/workflows/composites/run-and-save-test-times-when-cache-present/action.yaml
@@ -149,8 +149,9 @@ runs:
         
         ./mvnw -s .settings.xml \
               -DtestsToRun=${tests_to_run_in_current_index} \
+              -DCURRENT_INSTANCE=${CURRENT_INDEX} \
               -e clean install \
-              -P 'sonar, run-on-github-actions' -nsu --batch-mode \
+              -P sonar -nsu --batch-mode \
               -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
               -Dhttp.keepAlive=false \
               -Dmaven.wagon.http.pool=false \
diff --git a/pom.xml b/pom.xml
index 2f693f6818..271e4616b0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -62,6 +62,11 @@
 	</scm>
 
 	<properties>
+		<!-- in our github actions run, we save surefire/failsafe reports in a path that looks like this: -->
+		<!-- surefire-report/1/... , where "1" (and other numbers like this) are the index of the github matrix -->
+		<!-- where this is running. When outside the github actions, for example locally/jenkins, we will simply store -->
+		<!-- the reports in a directory: "surefire-reports/one/..." -->
+		<CURRENT_INSTANCE>one</CURRENT_INSTANCE>
 		<!-- Dependency Versions -->
 		<mockito-inline.version>4.8.1</mockito-inline.version>
 		<spring-cloud-commons.version>4.0.5-SNAPSHOT</spring-cloud-commons.version>
@@ -69,8 +74,6 @@
 		<spring-cloud-bus.version>4.0.1</spring-cloud-bus.version>
 		<spring-cloud-contract.version>4.0.5-SNAPSHOT</spring-cloud-contract.version>
 
-		<maven-surefire-plugin.version>3.1.0</maven-surefire-plugin.version>
-
 		<maven-checkstyle-plugin.failsOnError>true</maven-checkstyle-plugin.failsOnError>
 		<maven-checkstyle-plugin.failsOnViolation>true
 		</maven-checkstyle-plugin.failsOnViolation>
@@ -205,8 +208,18 @@
 					<includes>
 						<include>${testsToRun}</include>
 					</includes>
+					<reportsDirectory>${project.build.directory}/surefire-reports/${CURRENT_INSTANCE}</reportsDirectory>
+				</configuration>
+			</plugin>
+
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-failsafe-plugin</artifactId>
+				<configuration>
+					<reportsDirectory>${project.build.directory}/failsafe-reports/${CURRENT_INSTANCE}</reportsDirectory>
 				</configuration>
 			</plugin>
+
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-checkstyle-plugin</artifactId>
diff --git a/spring-cloud-kubernetes-integration-tests/pom.xml b/spring-cloud-kubernetes-integration-tests/pom.xml
index 1dae169f19..03363f509a 100644
--- a/spring-cloud-kubernetes-integration-tests/pom.xml
+++ b/spring-cloud-kubernetes-integration-tests/pom.xml
@@ -35,29 +35,6 @@
 
 	</build>
 
-	<profiles>
-		<profile>
-			<id>run-on-github-actions</id>
-			<build>
-				<pluginManagement>
-					<plugins>
-						<plugin>
-							<groupId>org.apache.maven.plugins</groupId>
-							<artifactId>maven-failsafe-plugin</artifactId>
-							<version>3.1.2</version>
-						</plugin>
-
-						<plugin>
-							<groupId>org.apache.maven.plugins</groupId>
-							<artifactId>maven-surefire-plugin</artifactId>
-							<version>3.1.2</version>
-						</plugin>
-					</plugins>
-				</pluginManagement>
-			</build>
-		</profile>
-	</profiles>
-
 	<dependencyManagement>
 		<dependencies>
 			<dependency>