Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to adjust spans before reporting them #553

Closed
marcingrzejszczak opened this issue Apr 3, 2017 · 1 comment
Closed

Add ability to adjust spans before reporting them #553

marcingrzejszczak opened this issue Apr 3, 2017 · 1 comment
Assignees
Milestone

Comments

@marcingrzejszczak
Copy link
Contributor

marcingrzejszczak commented Apr 3, 2017

Adding a functional interface to adjust the Zipkin's SpanBuilder before the Span is built and reported could allow to highly customize the built span according to one's needs without adding anything to the architecture.

For example for this issue #500 (comment) one could apply a customizer to verify the the tags to retrieve the URL and then rename the span accordingly.

Similar to this: https://github.com/openzipkin/zipkin-sparkstreaming#adjuster

cc @adriancole @ouaibsky @s-spindler

@marcingrzejszczak
Copy link
Contributor Author

Done here #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant