Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest highlightjs version #272

Open
rwinch opened this issue Nov 22, 2024 · 0 comments
Open

Update to latest highlightjs version #272

rwinch opened this issue Nov 22, 2024 · 0 comments

Comments

@rwinch
Copy link
Collaborator

rwinch commented Nov 22, 2024

Asciidoctor is using an older version of highlightjs which can cause highlight errors. For example the following will render with the latest version of highlightjs (you can try using https://highlightjs.org/demo ):

@Configuration
@EnableNeo4jRepositories(basePackages = "com.acme.repositories",
    includeFilters = { @Filter(type = FilterType.REGEX, pattern = ".*SomeRepository") },
    excludeFilters = { @Filter(type = FilterType.REGEX, pattern = ".*SomeOtherRepository") })
class ApplicationConfiguration {

  @Bean
  EntityManagerFactory entityManagerFactory() {
    // …
  }
}

However, rendered with the Spring documentation it the number in the annotation name causes it to highlight incorrectly:

image

Unfortunately, asciidoctor is on an older version of highlight.js and updating is non-trivial due to breaking changes See asciidoctor/asciidoctor#3976

We should try and update to the latest version of highlightjs and ideally contribute it back to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant