Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider skipping backport issue creation if original issue is not assigned a milestone #13

Open
sbrannen opened this issue Mar 12, 2019 · 0 comments

Comments

@sbrannen
Copy link

When I submitted spring-projects/spring-framework@0adabdb to spring-framework 4.3.x to close spring-projects/spring-framework#22520, I had initially forgotten to assign that PR to the next 4.3.x milestone.

Consequently, the bot automatically created spring-projects/spring-framework#22575 for the 4.3.x branch, under the assumption that I was in the process of performing a backport.

In this particular scenario, however, the merged PR and subsequent commit that closed the PR were only ever intended to be applied to the 4.3.x branch.

Thus, I was a bit confused that the bot created a backport issue for the same branch (4.3.x).

After some discussions with @rwinch, I think it would be better if the bot skipped the creation of the backport issue if the original PR/issue is not assigned a specific version (via a GitHub milestone). Instead, the bot could issue a warning in the form of a comment to the original issue indicating that the user should potentially take some manual actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant