Publish the plugin to the JetBrains Plugin Repository

[snicoll]

To make it easier for IntelliJ IDEA users to use this plugin, we should publish it to the JetBrains Plugin Repository, see the instructions.

As far as I can see, it requires to do so with an account so we should probably create one for the team or something.

[snicoll]

Let's increase the priority of this one please. It looks like the Jetbrains team is testing plugins that are published there and the recent breakage in 2020.1 could have been caught that way.

[vpavic]

Any updates on this?

Managing plugin updates manually is really a tedious chore, and that's far from being the only benefit of having the plugin published to Jetbrains plugin repo.

[philwebb]

I've not had a chance to look into it in any detail yet. I wonder if there's an API for updating a plugin. I don't like the idea of doing it manually for each release.

[vpavic]

I don't like the idea of doing it manually for each release.

I agree that automation is desirable, but isn't it overall much less of a hassle to publish manually compared to having everyone go through the manual download and installation?

[philwebb]

Yeah, I agree.

[vpavic]

It appears that the plugin was published to Jetbrains plugin repo as IntelliJ offered the plugin update to me today.

However, it's a bit unclear whether this was done by the Spring team or someone from the community?
See here for more details.

[philwebb]

It wasn't done by us. Looks like someone called Tony Cody uploaded it.

[snicoll]

I'll reach out to JetBrains.

[vpavic]

It seems that the plugin was removed from the Jetbrains plugin repo.

However this situation IMO makes it even more important to get the plugin (properly) published to repo as it seems that everyone who has it installed is under a risk of having it updated if someone else publishes a plugin with matching id (or whatever IntelliJ uses to match update candidates).

This opens a possibility for some quite nasty consequences.

[wilkinsona]

This opens a possibility for some quite nasty consequences.

Agreed. Hopefully JetBrains have put something in place that stops this from happening again.

[snicoll]

I asked them to remove it but they can't guarantee that it won't happen again. The person who published the jar had to modify it as the metadata are incomplete (I know that first hand trying to publish it yesterday).

I agree we need to put some priority on this, even if we have to publish it manually initially.

[tonycody]

It wasn't done by us. Looks like someone called Tony Cody uploaded it.

I'm so sorry. I uploaded it earlier. Source open source addresses have been added, but not officially released to the Jetbrains market yet. People who want to use the IDEA plugin need to build their own.

[snicoll]

People who want to use the IDEA plugin need to build their own.

They don't. This plugin is released on Maven Central so you can download it from there, or from repo.spring.io. It's true that it would be better if you could install it from the JetBrains market place, which is what we'll address in this issue.

[vpavic]

Honestly speaking, I'm uneasy about using the plugin at all until it gets uploaded to the plugin market properly (that is, by the Spring team). Last time it was (unofficially) uploaded just showed how easy it is for someone to take over a manually installed plugin. That incident occurred around a year and a half ago now - if I'm counting right, there were 6 releases since so it doesn't seem that uploading it manually from time to time would take so much time.

[scordio]

I'd love to see the IntelliJ plugin published to the JetBrains repository.

In certain projects where we use both the Maven and the IntelliJ plugins, the former usually gets updated by Dependabot. In some cases, this forced the next users who touch the codebase to perform the IDE plugin update immediately, otherwise the validate goal of the Maven plugin (enforced in the build) would fail if the IDE did a reformatting that is no longer compatible with the Maven plugin's expectations.

Obviously, spring-javaformat:apply can help in such situations. However, having the IDE pull the update would be very nice.

[fischermatte]

@snicoll I briefly read through the comments here. What is the state of this issue now in 2024? Why is this specific plugin not in the market place? Is it because mainting the constant publishing to jetbrains can't be automated?

[philwebb]

@fischermatte It's mainly that we haven't had the time to do the task. The project is mostly internal to Spring (although folks are welcome to use it) and it's not a high priority for us to get it on the marketplace.

[fischermatte]

@fischermatte It's mainly that we haven't had the time to do the task. The project is mostly internal to Spring (although folks are welcome to use it) and it's not a high priority for us to get it on the marketplace.

thx @philwebb for quick response. I really like this formatter due to its simplicity. We used prettier-java with spotless so far, but it comes with quite some verbose config.