Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore WebClient configuration based on RestClient configuration #1714

Open
asaikali opened this issue Nov 10, 2024 · 1 comment
Open

Explore WebClient configuration based on RestClient configuration #1714

asaikali opened this issue Nov 10, 2024 · 1 comment
Labels

Comments

@asaikali
Copy link

asaikali commented Nov 10, 2024

If users want to customize the HTTP interactions for models that support stream, they frequently have to provide a customized RestClient and WebClient which are customized using their own respective api. The user must have the skill to configure both the RestClient and the WebClient.

What if spring-ai offered the ability to configure a WebClient based on a RestClient configuration, this way the user only has to configure RestClient and spring-ai reads the configuration of the RestClient and configures the WebClient to match the settings in RestClient where the settings are common. This approach might reduce the effort required for users to perform simple common customizations.

Related issues:

@markpollack
Copy link
Member

This really feels like a boot issue, to provide configuration properties for all the http client libraries so that they can be configured. I do think the status quo ATM, for example to set timeouts or to enable logging of http requests is rather poor in terms of convenience from the foundational spring projects. Not sure why this hasn't been addressed already, can investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants