Skip to content

Commit 145f5ac

Browse files
committed
Rename functions from and fromOptimized to fromLegacy and from
1 parent ef51455 commit 145f5ac

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/main/java/org/springframework/data/elasticsearch/client/elc/DocumentAdapters.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ private DocumentAdapters() {
6666
* @param jsonpMapper to map JsonData objects
6767
* @return the created {@link SearchDocument}
6868
*/
69-
public static SearchDocument from(Hit<?> hit, JsonpMapper jsonpMapper) {
69+
@Deprecated
70+
public static SearchDocument fromLegacy(Hit<?> hit, JsonpMapper jsonpMapper) {
7071

7172
Assert.notNull(hit, "hit must not be null");
7273

@@ -151,7 +152,7 @@ public static SearchDocument from(Hit<?> hit, JsonpMapper jsonpMapper) {
151152
* @param jsonpMapper to map JsonData objects
152153
* @return the created {@link SearchDocument}
153154
*/
154-
public static SearchDocument fromOptimized(Hit<?> hit, JsonpMapper jsonpMapper) {
155+
public static SearchDocument from(Hit<?> hit, JsonpMapper jsonpMapper) {
155156

156157
Assert.notNull(hit, "hit must not be null");
157158

src/test/java/org/springframework/data/elasticsearch/client/elc/DocumentAdaptersBenchmark.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,22 +37,22 @@ public void setup() {
3737
mockHits = generateMockHits(100);
3838
}
3939

40-
public Object from() {
40+
public Object fromLegacy() {
4141
return mockHits.stream()
42-
.map(hit -> DocumentAdapters.from(hit, jsonpMapper))
42+
.map(hit -> DocumentAdapters.fromLegacy(hit, jsonpMapper))
4343
.collect(Collectors.toList());
4444
}
4545

46-
public Object fromOptimized() {
46+
public Object from() {
4747
return mockHits.stream()
48-
.map(hit -> DocumentAdapters.fromOptimized(hit, jsonpMapper))
48+
.map(hit -> DocumentAdapters.from(hit, jsonpMapper))
4949
.collect(Collectors.toList());
5050
}
5151

5252
@Test
5353
public void runner() {
54+
benchmark("fromLegacy", this::fromLegacy);
5455
benchmark("from", this::from);
55-
benchmark("fromOptimized", this::fromOptimized);
5656
}
5757

5858
private void benchmark(String name, Supplier<Object> func) {

0 commit comments

Comments
 (0)