Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder method to IndexQuery #3020

Open
kitkars opened this issue Dec 2, 2024 · 1 comment
Open

Add builder method to IndexQuery #3020

kitkars opened this issue Dec 2, 2024 · 1 comment
Labels
type: enhancement A general enhancement

Comments

@kitkars
Copy link

kitkars commented Dec 2, 2024

Is it ok to add a simple static builder method to the IndexQuery class? 😬

org.springframework.data.elasticsearch.core.query.IndexQuery

public static IndexQueryBuilder builder(){
   return new IndexQueryBuilder();
}

So that we could use it as shown below.

IndexQuery.builder()
                  .withObject(...)
                  ...
                 .build();
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 2, 2024
@sothawo sothawo added the type: enhancement A general enhancement label Dec 2, 2024
@sothawo
Copy link
Collaborator

sothawo commented Dec 2, 2024

Feel free to do so and submit a pull request.

@sothawo sothawo removed the status: waiting-for-triage An issue we've not yet triaged label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants