Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that the double semicolon in the Instant class member in DefaultRevisionMetadataUnitTests is a typo. #3669

Closed
PgmJun opened this issue Nov 8, 2024 · 0 comments
Closed

It seems that the double semicolon in the Instant class member in DefaultRevisionMetadataUnitTests is a typo. #3669

PgmJun opened this issue Nov 8, 2024 · 0 comments
Assignees
@mp911de
Labels
type: task A general task
Milestone
3.2.12 (2023.1.12)

Comments

@PgmJun
Copy link
Contributor

PgmJun commented Nov 8, 2024

DefaultRevisionMetadataUnitTests.java

class DefaultRevisionMetadataUnitTests {

	private static final Instant NOW = Instant.now();;

I was reading the test code and found these codes.
I think having 2 semicolons is a typo, so wouldn't it be okay to remove them?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 8, 2024
@PgmJun PgmJun mentioned this issue Nov 8, 2024
Closed
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 11, 2024
@mp911de mp911de self-assigned this Nov 11, 2024
mp911de pushed a commit that referenced this issue Nov 14, 2024
@PgmJun @mp911de
Polishing.
c9aa45e 
Remove unnecessary semicolons DefaultRevisionMetadataUnitTests class.

Original pull request: #3670
Closes #3669
mp911de pushed a commit that referenced this issue Nov 14, 2024
@PgmJun @mp911de
Polishing.
5fa723c 
Remove unnecessary semicolons DefaultRevisionMetadataUnitTests class.

Original pull request: #3670
Closes #3669
@mp911de mp911de added this to the 3.2.12 (2023.1.12) milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
3.2.12 (2023.1.12)
3 participants
@mp911de @spring-projects-issues @PgmJun