-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription on netty http not working #458
Comments
Could you provide a sample application showing the issue? Ideally, an application created on https://start.spring.io, that we can git clone and run. |
@bclozel You can clone from here: https://github.com/calebcodesgud/sgql-streaming-issue/tree/main Forgive the lack of a virtual environment please, I've included my jdk and maven version in the read me. |
@calebcodesgud I think this was mostly an issue with the testing setup. I'm closing this as the feature works as expected. Thanks! |
@bclozel Changing the test implementation here doesn't really solve the issue as I see the same problem when the application is deployed and called via webclient... should I be using a different client to execute the http subscription? |
We're shipping a dedicated client for that case. In your original project you were using a mix of graphql-kickstart and hand-made HTTP requests. Also, currently only the WebSocket transport supports subscriptions. |
Thanks @bclozel ! is adding http subscription support in the roadmap at all? |
@calebcodesgud Not right now, see this comment for more context. |
Same here, but I think we're trying to do get/post htpp request. It should be performed wss from what I understand. |
I have a @SubscriptionMapping datafetcher which returns a flux. The data fetcher returns the flux to the client reactively when I run spring graphql on a websocket server and I'm happy with its performance. However, when I run spring graphql on netty webflux, the same datafetcher just returns:
{"data":{"upstreamPublisher":{"scanAvailable": true, "prefetch": -1}}}
and then terminates...
The only other reference to this that I can find is spring-projects/spring-boot#30052
This made against the spring projects repo by that developer and was closed for not providing enough information.
Please let me know if you need more from me. Thank you!
The text was updated successfully, but these errors were encountered: