Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable automatic jMolecules ArchUnit rule verification #828

Open
xenoterracide opened this issue Sep 18, 2024 · 3 comments
Open
Assignees
Labels
in: core Core module meta model meta: waiting for feedback Waiting for feedback of the original reporter type: enhancement Major enhanvements, new features

Comments

@xenoterracide
Copy link

Due to what appears to be a bug in archunit I'm looking at possibly writing this integration testing manually but the documentation doesn't seem to imply that I can disable this if I provide archunit.

Spring Modulith optionally integrates with the jMolecules ArchUnit library and, if present, automatically triggers its Domain-Driven Design verification rules described here.

not certain if this is a missing feature or simply a need to document.

@odrotbohm
Copy link
Member

Can you elaborate on what the actual problem is? You have the jMolecules ArchUnit rules on the test classpath but do not want to execute them?

@odrotbohm odrotbohm self-assigned this Sep 19, 2024
@odrotbohm odrotbohm added in: core Core module meta model type: enhancement Major enhanvements, new features labels Sep 19, 2024
@odrotbohm odrotbohm changed the title option to disable jmolecules archunit Add option to disable automatic jMolecules ArchUnit rule verification Sep 19, 2024
@xenoterracide
Copy link
Author

xenoterracide commented Sep 19, 2024

I'm encountering a bug (their's not yours) and I'm trying to work around it. Either by customizing the rules executed, or disabling them all together and then writing my own archunit test.

This is the bug.

xmolecules/jmolecules-integrations#259

@odrotbohm odrotbohm added the meta: waiting for feedback Waiting for feedback of the original reporter label Sep 20, 2024
@xenoterracide
Copy link
Author

xenoterracide commented Sep 23, 2024

I think that this should be remediated on similar principals to spring boots autoconfiguration. You can let spring boot be auto-configured until you start telling it not to, or you start overriding it. This is the same case. Right now my workaround will probably be another JvmTestSuite so I can choose which rules to enforce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Core module meta model meta: waiting for feedback Waiting for feedback of the original reporter type: enhancement Major enhanvements, new features
Projects
None yet
Development

No branches or pull requests

2 participants