Implemented selenium automation tests for all functionalities

[TodorovskiMarko]

No description provided.

[pivotal-cla]

@TodorovskiMarko Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@TodorovskiMarko Thank you for signing the Contributor License Agreement!

[dsyer]

Is it necessary to add TestNG in order to have Selenium tests? If not, would it be better to stick with JUnit, the same as the rest of the project?

[TodorovskiMarko]

Is it necessary to add TestNG in order to have Selenium tests? If not, would it be better to stick with JUnit, the same as the rest of the project?

Yes, you are right, I reimplemented it. While I was learning Selenium, I used TestNG and was familiar with it, so that's why I initially used it on this project.

[Vigrind]

I have some suggestions:
In TestBase when driver options are created, add the "--lang=en" argument. This way, if the test is started from a non-English language driver there will be no problems.
Also change "--headless" to ""--headless=new" for the ChromeOptions, here the reference: https://www.selenium.dev/blog/2023/headless-is-going-away/

Change the isPetNameDisplayed function in OwnerPage to something like:

	public boolean isPetNameDisplayed(String petName) {
		// FIX: petDetailsText need to be a list of string and not a normal String
		List<WebElement> petDetails = driver.findElements(petDetailsClass);
		List<String> petDetailsText = new ArrayList<>(petDetails.size());

		for (WebElement petItem : petDetails) {
			petDetailsText.add(petItem.getText());
		}

		String expectedPetName = input.getProperty(petName);

		for (String petDetailsItem : petDetailsText) {
			if (petDetailsItem.contains(expectedPetName))
				return true;
		}

		return false;
	}

driver.findElements(petDetailsClass) returns a list of elements, not 1
Sorry for my english end happy coding <3

[dsyer]

Yes, you are right, I reimplemented it. While I was learning Selenium, I used TestNG and was familiar with it, so that's why I initially used it on this project.

Thanks. Can you make sure to run the build locally to check for failures? It just needs a formatter to be applied I think.

[TodorovskiMarko]

I have some suggestions: In TestBase when driver options are created, add the "--lang=en" argument. This way, if the test is started from a non-English language driver there will be no problems. Also change "--headless" to ""--headless=new" for the ChromeOptions, here the reference: https://www.selenium.dev/blog/2023/headless-is-going-away/

Change the isPetNameDisplayed function in OwnerPage to something like:

	public boolean isPetNameDisplayed(String petName) {
		// FIX: petDetailsText need to be a list of string and not a normal String
		List<WebElement> petDetails = driver.findElements(petDetailsClass);
		List<String> petDetailsText = new ArrayList<>(petDetails.size());

		for (WebElement petItem : petDetails) {
			petDetailsText.add(petItem.getText());
		}

		String expectedPetName = input.getProperty(petName);

		for (String petDetailsItem : petDetailsText) {
			if (petDetailsItem.contains(expectedPetName))
				return true;
		}

		return false;
	}

driver.findElements(petDetailsClass) returns a list of elements, not 1 Sorry for my english end happy coding <3

Thank you for the suggestions. I updated the driver options. For the isPetNameDisplayed function, I used Java Streams to make the code more concise and readable.

[TodorovskiMarko]

Yes, you are right, I reimplemented it. While I was learning Selenium, I used TestNG and was familiar with it, so that's why I initially used it on this project.

Thanks. Can you make sure to run the build locally to check for failures? It just needs a formatter to be applied I think.

I've applied the formatter. The build was successful.

[mosbat]

is this still actual? If any help needed, I might offer help.

[dsyer]

I left it open in case anyone wanted to see how it is done. No plans to merge, but you could help by rebasing and making sure it works on today’s main.

[mosbat]

I left it open in case anyone wanted to see how it is done. No plans to merge, but you could help by rebasing and making sure it works on today’s main.

Sounds good. Will check it out!