Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display default login page with only one-time token login #16414

Closed
Kehrlann opened this issue Jan 14, 2025 · 2 comments
Closed

Display default login page with only one-time token login #16414

Kehrlann opened this issue Jan 14, 2025 · 2 comments
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone

Comments

@Kehrlann
Copy link
Contributor

Kehrlann commented Jan 14, 2025

Expected Behavior

One time token login has a dedicated field and button on the default login page (DefaultLoginPageGeneratingFilter).
Given the following configuration:

http.authorizeHttpRequests(...)
    .oneTimeTokenLogin(...)
    .build();

The default login page should be displayed, with the one time token login form.

Current Behavior

Currently, OTT alone does not enable the default login page UI. There MUST be one of formLogin, oauth2Login or saml2Login configured for the login page to be active. This is true for both Servlet and Reactive.


Planning to submit a PR for this.

@Kehrlann Kehrlann added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jan 14, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 4, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Feb 4, 2025

Closing in favor of #16480

@jzheaux jzheaux closed this as completed Feb 4, 2025
@jzheaux jzheaux self-assigned this Feb 4, 2025
Kehrlann added a commit to Kehrlann/spring-security that referenced this issue Feb 5, 2025
rwinch pushed a commit that referenced this issue Feb 10, 2025
closes gh-16414

Signed-off-by: Daniel Garnier-Moiroux <[email protected]>
@rwinch rwinch removed the status: duplicate A duplicate of another issue label Feb 10, 2025
@rwinch rwinch added this to the 6.5.0-M2 milestone Feb 10, 2025
@rwinch
Copy link
Member

rwinch commented Feb 10, 2025

Changing to no longer be a duplicate since we used the PR to close multiple issues and we want specific ticket in the change log

@rwinch rwinch assigned rwinch and jzheaux and unassigned jzheaux Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants