Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialize/deserialize PublicKeyCredentialRequestOptions support with ObjectMapper #16433

Open
rwinch opened this issue Jan 16, 2025 · 1 comment
Open

Add serialize/deserialize PublicKeyCredentialRequestOptions support with ObjectMapper #16433

rwinch opened this issue Jan 16, 2025 · 1 comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Jan 16, 2025 •
edited
Loading

Spring Security should add support for serialize/deserialize PublicKeyCredentialRequestOptions with ObjectMapper so it is easier to persist with Spring Session.

NOTE: WebauthnJackson2Module is used for reading/writing to the HTTP Response which includes untrusted inputs. This means that it cannot enable default-typing otherwise it could create deserialization vulnerabilities.
@rwinch rwinch added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jan 16, 2025
@justincranford
Copy link

I will give it a go.

justincranford added a commit to justincranford/spring-security that referenced this issue Jan 20, 2025
@justincranford
Add serialize/deserialize PublicKeyCredentialCreationOptions and Publ…
bab5868 
…icKeyCredentialRequestOptions support with ObjectMapper

spring-projectsgh-16433 PublicKeyCredentialRequestOptions
spring-projectsgh-16434 PublicKeyCredentialCreationOptions
@justincranford justincranford mentioned this issue Jan 20, 2025
Draft
justincranford added a commit to justincranford/spring-security that referenced this issue Jan 20, 2025
@justincranford
Add serialize/deserialize PublicKeyCredentialCreationOptions and Publ…
802191d 
…icKeyCredentialRequestOptions support with ObjectMapper

spring-projectsgh-16433 PublicKeyCredentialRequestOptions
spring-projectsgh-16434 PublicKeyCredentialCreationOptions
justincranford added a commit to justincranford/spring-security that referenced this issue Jan 25, 2025
@justincranford
Add serialize/deserialize PublicKeyCredentialCreationOptions and Publ…
c4c27dc 
…icKeyCredentialRequestOptions support with ObjectMapper

Signed-off-by: Justin Cranford <[email protected]>

spring-projectsgh-16433 PublicKeyCredentialRequestOptions
spring-projectsgh-16434 PublicKeyCredentialCreationOptions
justincranford added a commit to justincranford/spring-security that referenced this issue Jan 25, 2025
@justincranford
Add serialize/deserialize PublicKeyCredentialCreationOptions and Publ…
cff73af 
…icKeyCredentialRequestOptions support with ObjectMapper

Signed-off-by: Justin Cranford <[email protected]>

spring-projectsgh-16433 PublicKeyCredentialRequestOptions
spring-projectsgh-16434 PublicKeyCredentialCreationOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @justincranford