Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WebAuthnAuthenticationTokenRequest Serializable #16481

Open
jzheaux opened this issue Jan 24, 2025 · 3 comments
Open

Make WebAuthnAuthenticationTokenRequest Serializable #16481

jzheaux opened this issue Jan 24, 2025 · 3 comments
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 24, 2025

WebAuthAuthenticationTokenRequest should be serializable. It isn't, however, since some of its components aren't serializable. Either they should also be serializable or marked as transient.

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug labels Jan 24, 2025
@jzheaux jzheaux added this to the 6.4.x milestone Jan 24, 2025
@franticticktick
Copy link
Contributor

Hi @jzheaux, could you assign this ticket to me please?

@jzheaux jzheaux modified the milestones: 6.4.x, 6.4.3 Jan 25, 2025
@jzheaux
Copy link
Contributor Author

jzheaux commented Jan 25, 2025

Sure thing, @franticticktick. Will you please add it on the 6.4.x branch, please?

@franticticktick
Copy link
Contributor

@jzheaux there seems to be some confusion here. WebAuthnAuthenticationRequestToken contains RelyingPartyAuthenticationRequest, and it already contains PublicKeyCredentialRequestOptions.
This issue should be solved here, and I see that this ticket is still in progress. Besides, it was not introduced as a bug, which means the changes will be merged into main. Therefore, we need to decide which branch to add these changes to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants