Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractUserDetailsAuthenticationProvider should lazily compose debug message #16495

Open
jzheaux opened this issue Jan 28, 2025 · 0 comments
Open
Labels
in: web An issue in web modules (web, webmvc) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 28, 2025

AbstractUserDetailsAuthenticationProvider logs the following:

this.logger.debug("Failed to find user '" + username + "'")

This could be improved by not composing the message regardless of logging level. LogMessage is a nice utility for this;

this.logger.debug(LogMessage.format("Failed to find user '%s'", username));

This makes so that the message is only concatenated if the logging level is DEBUG or higher.

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement labels Jan 28, 2025
@jzheaux jzheaux changed the title AbstractUserDetailsAuthenticationProvider should lazily compose message AbstractUserDetailsAuthenticationProvider should lazily compose debug message Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant