Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOAP WS-Addressing MessageId header is always required when receiving message using Addressing10 (http://www.w3.org/2005/08/addressing) #1427

Open
greenman18523 opened this issue Aug 8, 2024 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@greenman18523
Copy link

greenman18523 commented Aug 8, 2024

org.springframework.ws.soap.addressing.server.AddressingEndpointInterceptor creates the org.springframework.ws.soap.addressing.core.MessageAddressingProperties of the request using org.springframework.ws.soap.addressing.version.AddressingVersion.getMessageAddressingProperties(SoapMessage), and then checks if the required properties are present using org.springframework.ws.soap.addressing.version.AddressingVersion.hasRequiredProperties(MessageAddressingProperties)

getMessageAddressingProperties defaults replyTo and faultTo to anonymous (based in org.springframework.ws.soap.addressing.version.Addressing10.getDefaultReplyTo(EndpointReference)) thus when org.springframework.ws.soap.addressing.version.Addressing10.hasRequiredProperties(MessageAddressingProperties) is called the replyTo and faultTo are never null, but the code only checks if they are not null in order to require messageId.

The code should probably also check if they are anonymous (since anonymous URIs will results in a synchronous response, and not an out of band response) or none address (since reply will be discarded).

@snicoll snicoll added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

2 participants