-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move spring-social-google into spring-projects #66
Comments
Thank you @GabiAxel :) |
Be interesting to see this moved over, for sure. |
Please note that I wasn't suggesting that moving this project to the |
@GabiAxel Hi! I've got a pull request ready for adding spring boot auto configuration. What do you say? |
Before moving it over, I'd like us to hook into Travis and Coveralls, just to get the quality assurance taken care of. After that, I don't see it being a problem. |
Are there many people currently maintaining this? I would like to join as a contributor. |
Hi @GabiAxel
I sent a spring-boot PR (spring-projects/spring-boot#2548) to add spring boot starter for spring social google. But since spring-social-google is not spring projects, they put it on-hold.
Since spring social already has Twitter, Facebook, LinkedIn, I suggest to move spring-social-google into spring-projects. And this project will have better support from spring team. It will be very trivial code changes, since the code base follows the exact same pattern of other spring social projects.
What do you think?
Thanks.
The text was updated successfully, but these errors were encountered: