Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spring-social-google into spring-projects #66

Open
jiwhiz opened this issue Apr 11, 2015 · 7 comments
Open

Move spring-social-google into spring-projects #66

jiwhiz opened this issue Apr 11, 2015 · 7 comments

Comments

@jiwhiz
Copy link

jiwhiz commented Apr 11, 2015

Hi @GabiAxel

I sent a spring-boot PR (spring-projects/spring-boot#2548) to add spring boot starter for spring social google. But since spring-social-google is not spring projects, they put it on-hold.

Since spring social already has Twitter, Facebook, LinkedIn, I suggest to move spring-social-google into spring-projects. And this project will have better support from spring team. It will be very trivial code changes, since the code base follows the exact same pattern of other spring social projects.

What do you think?

Thanks.

@GabiAxel
Copy link
Collaborator

Greetings @jiwhiz ,

Makes sense to me, but it's not really my decision.

@habuma - what do you say?

@jiwhiz
Copy link
Author

jiwhiz commented Apr 12, 2015

Thank you @GabiAxel :)

@mlaccetti
Copy link
Collaborator

Be interesting to see this moved over, for sure.

@wilkinsona
Copy link

Please note that I wasn't suggesting that moving this project to the spring-projects organisation was necessarily the right thing to do. The other option is to update the group id so that it isn't in the org.springframework namespace. This would make it clear that this is a third-party Spring Social module rather than one that's developed and supported by the Spring team.

@leon
Copy link
Contributor

leon commented Oct 14, 2015

@GabiAxel Hi!
I've been talking to @dsyer about moving this into spring-projects
The problem is finding people to maintain the repo.
So my suggestion would be that there could be a couple of us to maintain it.

I've got a pull request ready for adding spring boot auto configuration.
And I could do the initial move if they setup a new repo for us.

What do you say?

@mlaccetti
Copy link
Collaborator

Before moving it over, I'd like us to hook into Travis and Coveralls, just to get the quality assurance taken care of. After that, I don't see it being a problem.

@patons02
Copy link

patons02 commented Dec 9, 2016

Are there many people currently maintaining this? I would like to join as a contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants