Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the c-header__show-text class from the Nature Header #644

Open
amyhupe opened this issue Dec 21, 2021 · 2 comments
Open

Remove the c-header__show-text class from the Nature Header #644

amyhupe opened this issue Dec 21, 2021 · 2 comments
Labels
nature nature toolkit issue role: FED role: UX stale this issue is more than 30 days old

Comments

@amyhupe
Copy link
Contributor

amyhupe commented Dec 21, 2021

In the Nature Header component we include the class c-header__show-text.

This is used with a <span> to shorten some of our navigation menu text labels on mobile.

For example, the "Explore content" navigation link in the nature.com header becomes "Content" on mobile, as follows:

<span><span class="c-header__show-text">Explore</span> content</span>

I suggest we stop doing this and remove the class from the header's stylesheet because:

  • we should always design the shortest understandable text label. Using the above example, if "Content" is good enough on mobile, we should use it on desktop, too. If users need "Explore content" to understand it, we should use that on mobile
  • we shouldn't solve design problems by changing content
  • it complicates the code unnecessarily
  • it's not really in the spirit of progressive enhancement

This may prompt questions about how the navigation menu should behave on mobile. Currently, when the menu is wider than the viewport, it wraps:

image

I've talked this over with @benjclark and @foxintherain and we agreed to raise this issue to discuss:

  • removing the c-header__show-text class`
  • if we want to make any changes to the labels on nature.com / other places using the header
  • if we're happy with the behaviour on smaller screens
@amyhupe amyhupe added nature nature toolkit issue role: UX role: FED labels Dec 21, 2021
@foxintherain
Copy link
Contributor

Will organize a chat with Rosario (UX from Pandora) to discuss what we are thinking

@sturobson
Copy link
Contributor

There has been no update on this issue for 30 days. It is now marked as "stale". If you think this issue is still relevant and needs attention then reply with an update. If there is no update in 14 days, this issue will be closed.

@sturobson sturobson added the stale this issue is more than 30 days old label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nature nature toolkit issue role: FED role: UX stale this issue is more than 30 days old
Projects
None yet
Development

No branches or pull requests

3 participants