Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for abstracts.scss #680

Open
aliuk2012 opened this issue Feb 9, 2022 · 1 comment
Open

Add tests for abstracts.scss #680

aliuk2012 opened this issue Feb 9, 2022 · 1 comment
Labels
enhancement New feature or request stale this issue is more than 30 days old

Comments

@aliuk2012
Copy link
Contributor

I think if we offer an option for developers to import all the settings/functions/mixins etc through abstract.scss then we perhaps we should add a test to check that for each file in these groups have an import statement in abstracts.scss

I suppose an alternative approach might be to create a script to dynamically create abstract.scss as part of deploying brand-context for each but this might be tricky if files need to be imported in a specific order.

Either way the intent is to not have PR like #679

@aliuk2012 aliuk2012 added the enhancement New feature or request label Feb 9, 2022
@sturobson
Copy link
Contributor

There has been no update on this issue for 30 days. It is now marked as "stale". If you think this issue is still relevant and needs attention then reply with an update. If there is no update in 14 days, this issue will be closed.

@sturobson sturobson added the stale this issue is more than 30 days old label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale this issue is more than 30 days old
Projects
None yet
Development

No branches or pull requests

2 participants