You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently throughout the demos created from components in the toolkits there are many urls being used for examples of links being used.
This, when part of the Elements Design System is fine until folks click the link and are taken to that url inside the iframe of the demo.
To rectify this, and keep folks 'on the page' without a distracting new website inside it, or a 404. We should move to replace any example urls with JavaScript:Void(0);.
Why JavaScript:Void(0); and not #.
If we used # when. a link is clicked, chance are the next time a Design System consumer visits the page, they would see the :visisted state. Ideally these would/should be shown separately in the docs.
To combat the potential :visited state and make it so that consumers of the Design System site can state on the page. We should implement JavaScript:Void(0); on all urls in the context.json file in the demofolder
The text was updated successfully, but these errors were encountered:
This looks like it affects 7 existing components and their /demo/dist/index.html files.
global-ad
global-banner
global-card
global-menu
springer-dropdown
springer-header
springer-hero
As the urls are generated from the context.json file for each component I'm not entirely convinced it warrants any version bumping. It's not changing HTML structure, it's not changing any styling from CSS and it's not effecting any functionality that may be in a JavaScript file.
Currently throughout the demos created from components in the toolkits there are many urls being used for examples of links being used.
This, when part of the Elements Design System is fine until folks click the link and are taken to that url inside the iframe of the demo.
To rectify this, and keep folks 'on the page' without a distracting new website inside it, or a 404. We should move to replace any example urls with
JavaScript:Void(0);
.Why
JavaScript:Void(0);
and not#
.If we used
#
when. a link is clicked, chance are the next time a Design System consumer visits the page, they would see the:visisted
state. Ideally these would/should be shown separately in the docs.To combat the potential
:visited
state and make it so that consumers of the Design System site can state on the page. We should implementJavaScript:Void(0);
on all urls in thecontext.json
file in thedemo
folderThe text was updated successfully, but these errors were encountered: