Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs in component demos to JavaScript:Void(0); #766

Closed
sturobson opened this issue Jul 14, 2022 · 3 comments
Closed

Update URLs in component demos to JavaScript:Void(0); #766

sturobson opened this issue Jul 14, 2022 · 3 comments

Comments

@sturobson
Copy link
Contributor

Currently throughout the demos created from components in the toolkits there are many urls being used for examples of links being used.

This, when part of the Elements Design System is fine until folks click the link and are taken to that url inside the iframe of the demo.

To rectify this, and keep folks 'on the page' without a distracting new website inside it, or a 404. We should move to replace any example urls with JavaScript:Void(0);.

Why JavaScript:Void(0); and not #.

If we used # when. a link is clicked, chance are the next time a Design System consumer visits the page, they would see the :visisted state. Ideally these would/should be shown separately in the docs.
To combat the potential :visited state and make it so that consumers of the Design System site can state on the page. We should implement JavaScript:Void(0); on all urls in the context.json file in the demofolder

@sturobson
Copy link
Contributor Author

This looks like it affects 7 existing components and their /demo/dist/index.html files.

  • global-ad
  • global-banner
  • global-card
  • global-menu
  • springer-dropdown
  • springer-header
  • springer-hero

As the urls are generated from the context.json file for each component I'm not entirely convinced it warrants any version bumping. It's not changing HTML structure, it's not changing any styling from CSS and it's not effecting any functionality that may be in a JavaScript file.

@sturobson
Copy link
Contributor Author

We would also need this to update the global-skip-link

@sturobson
Copy link
Contributor Author

this will be part of the new Elements Documentation Site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant