Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line height issue #789

Open
3 tasks done
Heydon opened this issue Aug 10, 2022 · 4 comments
Open
3 tasks done

Line height issue #789

Heydon opened this issue Aug 10, 2022 · 4 comments
Assignees
Labels
blocked Something that is dependent on another issue or a person who isn't here stale this issue is more than 30 days old

Comments

@Heydon
Copy link
Contributor

Heydon commented Aug 10, 2022

Default line-height values for springernature and nature are remarkably large. This is affecting the spacing in some of our components (e.g. global-forms) and should be addressed.

  • Reduce line-height experimentally
  • Set up demo app (based off springercom-toolkits-demo) with "kitchen sink" of flow elements to test it with
  • Pair with James to tweak
@foxintherain
Copy link
Contributor

foxintherain commented Sep 29, 2022

Following a call with @Heydon we agreed on these changes to the brand context:

  • For Springer Nature brand, value line height body text will be 1.625.
  • For Springer and Nature brands line height body text will be 1.5

@amyhupe
Copy link
Contributor

amyhupe commented Dec 14, 2022

Reviewed in planning today. Next step is @Heydon to change line heights as per previous comment.

Will need to check impact on Nature because footer line height has been overridden.

@sturobson
Copy link
Contributor

There has been no update on this issue for 30 days. It is now marked as "stale". If you think this issue is still relevant and needs attention then reply with an update. If there is no update in 14 days, this issue will be closed.

@sturobson sturobson added the stale this issue is more than 30 days old label Jan 11, 2023
@amyhupe
Copy link
Contributor

amyhupe commented Jan 11, 2023

Have agreed to park this for now and include as part of the single package release repo, to minimise breaking changes to product teams consuming the current version of the toolkits.

Moving back into backlog and will pick up when ready.

@amyhupe amyhupe added the blocked Something that is dependent on another issue or a person who isn't here label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something that is dependent on another issue or a person who isn't here stale this issue is more than 30 days old
Projects
None yet
Development

No branches or pull requests

4 participants