Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

focus state should have a 4px border #869

Open
7 tasks
sturobson opened this issue Jan 17, 2023 · 0 comments
Open
7 tasks

focus state should have a 4px border #869

sturobson opened this issue Jan 17, 2023 · 0 comments
Labels
bug Something isn't working global global toolkit issue good first pr

Comments

@sturobson
Copy link
Contributor

sturobson commented Jan 17, 2023

What

Currently the focus state on forms elements has a 3px border. Looking at the sketch library it's 4px.

Why

To have consistency between design and development expectations when using elements that can have focus states.

Done When

  • The component specific design token is updated
  • That value is seen in the global-forms.tokens.scss file
  • The global-forms demo html file has been updated
  • The demo.html has been tested to show the change
  • The history.md of the Design Tokens is updated
  • The history.md of the global-forms is updated
  • The package.json of the `global-forms is updated

Notes

  • as the Design Tokens for this front-end toolkits codebase are not versioned we do not need to create a new brand-context PR
@sturobson sturobson added bug Something isn't working global global toolkit issue good first pr labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working global global toolkit issue good first pr
Projects
None yet
Development

No branches or pull requests

1 participant