Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support #113

Open
1 of 4 tasks
tavvy opened this issue Mar 14, 2016 · 3 comments
Open
1 of 4 tasks

Add https support #113

tavvy opened this issue Mar 14, 2016 · 3 comments

Comments

@tavvy
Copy link
Contributor

tavvy commented Mar 14, 2016

#112 added support for surfacing the protocol of the --route-override route, defaulting to http:.

As inspired by @moddular's comment on the PR:

With the http/https bit it doesn't seem to change anything in lib/processor.js where the proxy target is created:

route.target = 'http://' + route.host + (route.port ? ':' + route.port : '');

Should this maybe return the scheme too so that could be used here (with a default of http)?

So with the protocol now being exposed, we could potentially add support for https: by adding a little logic to the route.target definition. As far as I can see this would require the following changes:

  • Support for defining the protocol in the routes config file
  • Support for defining the protocol via --route-override
  • Updating the route.target logic to allow changing of the protocol, defaulting to http:
  • Investigating the impact of using https and if there are further changes required in order to fully support it. (Encryption etc).
@andrewmee
Copy link
Contributor

This is something we'd like to do, but we're waiting for a practical application so that we can test it all works as expected. At the moment all our use of Shunter uses http internally.

@jpw
Copy link
Contributor

jpw commented Mar 24, 2017

Am I missing something, or does it work now? https://journalsuggester.springer.com/

nvm I am missing something, using it internally. Sorry!

@jpw jpw self-assigned this Oct 2, 2018
@jpw
Copy link
Contributor

jpw commented Oct 2, 2018

Self-assigning as we may need to add this ourselves for a project here at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants