New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not import assets directly on the HTML #47

Closed

chitty opened this issue Apr 7, 2017 · 1 comment

Assignees

Labels

Contributor

chitty commented Apr 7, 2017

Related to #46.

We should not be importing CSS (https://github.com/spry-group/trashradar/blob/625623f637eb110d3e4dd0452658104827489039/tr-site/src/index.html#L9) or JS (https://github.com/spry-group/trashradar/blob/625623f637eb110d3e4dd0452658104827489039/tr-site/src/index.html#L15) in hte HTML.

We should be using https://ng-bootstrap.github.io for bootstrap.

chitty assigned Klemensas

Klemensas mentioned this issue

Import fixes spry-group/trashradar#20

Merged

Klemensas added the front-end label

Klemensas commented Apr 7, 2017

Solved by spry-group/trashradar#21

Klemensas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment