-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to generate a ContributesBinding baseline? #875
Comments
is baseline the right word for this? Seems more like something similar to compose's compiler reports. Sidenote - BindingModuleGenerator.kt is going away soon |
I wanted to call it baseline because like Android lint or dependency-guard, I'd want to see in source control that my baseline changed. This is because it's so easy to introduce a I was on a project previously where an important upgrade checking feature was being replaced by a fake implementation and it was undiscovered for a year. For my use case, a report could be useful, but wouldn't help me automatically detect these sorts of changes. |
So you want something like a lock file for replacements? |
Yes, and for ordering/priority. |
tbh this is probably a non-starter. See google/ksp#1677 |
Thanks for linking that issue. Makes sense, but that's unfortunate. |
The KSP issue above only applies to KSP. This is still on the table for embedded mode. |
Could you generate a file that contains the following (see snippet) using
anvil/compiler/src/main/java/com/squareup/anvil/compiler/codegen/BindingModuleGenerator.kt
Lines 58 to 60 in aa24f31
This sort of baseline would be incredibly useful in many cases and for debugging.
Writing out
replaces
is also something that would be nice to call out in bindings. I've seen bugs and issues come up when it wasn't known that a replaces was happening.This file could be generated per module.
This file would get noisy in Git. Maybe just having the
replaces
only in the baseline by default would be good?The text was updated successfully, but these errors were encountered: