Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeFunction waits for all arguments to finish, even when one argument returns an error fast #313

Open
Nathan-Fenner opened this issue Jul 1, 2016 · 0 comments

Comments

@Nathan-Fenner
Copy link
Contributor

Nathan-Fenner commented Jul 1, 2016

This can make some queries like

cpu.usage / cpu.total
from -30m to now

take a long time to error, if (say) the limit is 5000 series and there are 3000 of each of these; the first one to be evaluated will completion in about 5 seconds, and the second will be instantly rejected for exceeding the number of allowable series. The overall query will thus take about 5 seconds, even though it could instantly return an error instead (and cancel its request).

This only matters if the query is going to return an error anyway, so optimizing this is not a priority.

@Nathan-Fenner Nathan-Fenner changed the title MakeFunction waits for arguments to finish, even when one argument returns an error fast MakeFunction waits for all arguments to finish, even when one argument returns an error fast Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant