Field serialized despite of the Transient annotation

[alizeec]

Hello!
I have an issue with the @Transient annotation. I'm trying to serialize this model. The field "type" is in the payload, where it shouldn't be because of the @Transient annotation, correct?

@JsonClass(generateAdapter = true)
data class ApiNewReviewCollectionBodyRequest(
    @Json(name = "identifier")
    val id: String,
    @Json(name = "value")
    val value: ApiBodyRequestValue,
)

interface ApiBodyRequestValue {
    val type: String

    companion object {
        val adapterFactory: PolymorphicJsonAdapterFactory<ApiBodyRequestValue> =
            PolymorphicJsonAdapterFactory.of(ApiBodyRequestValue::class.java, "type")
                .withSubtype(
                    ValueRate::class.java,
                    "rate",
                )
                .withSubtype(
                    ValueComment::class.java,
                    "comment",
                )
    }
}

@JsonClass(generateAdapter = true)
data class ValueRate(val rate: Float) :
    ApiBodyRequestValue {
    @Transient
    override val type = "rate"
}

@JsonClass(generateAdapter = true)
data class ValueComment(val comment: String) :
    ApiBodyRequestValue {
    @Transient
    override val type =  "comment"
}

gives me

id: "ID",
value: {
   rate: 4
   type: "rate"
}

and I want

id: "ID",
value: {
   rate: 4
}

Do you have any idea why ?

Thanks

[ZacSweers]

@Transient is translated as the transient modifier in the JVM, which is only applicable on fields. Since this is a property, it wouldn't be visible. Instead, you can use @Json(ignore = true)

[alizeec]

Thanks for your answer.

I tried with @Json(ignore = true) instead of @Transient and I still have the same result.

[ZacSweers]

Can you share a minimally reproducing snippet?

[alizeec]

Sure. Here is my class

interface ApiBodyRequestValue {
    val type: String

    companion object {
        val adapterFactory: PolymorphicJsonAdapterFactory<ApiBodyRequestValue> =
            PolymorphicJsonAdapterFactory.of(ApiBodyRequestValue::class.java, "type")
                .withSubtype(
                    ValueRate::class.java,
                    "rate",
                )
                .withSubtype(
                    ValueComment::class.java,
                    "comment",
                )
    }
}

@JsonClass(generateAdapter = true)
data class ValueRate(val rate: Float) :
    ApiBodyRequestValue {
    @Json(ignore = true)
    override val type = "rate"
}

@JsonClass(generateAdapter = true)
data class ValueComment(val comment: String) :
    ApiBodyRequestValue {
    @Json(ignore = true)
    override val type =  "comment"
}

and my test

private val moshi = Moshi.Builder().add(ApiBodyRequestValue.adapterFactory).build()

    @Test
    fun `test serialization rate`() {
        val answer = ValueRate(3.4f)
        val result = """{"rate":3.4}"""

        given(moshi) whenThisResult {
            this.adapter(ApiBodyRequestValue::class.java).toJson(answer)
        } then {
            assert {
                this mustBeEqualTo result
            }
        }
    }

result is expected:<{"rate":3.4}> but was:<{"type":"rate","rate":3.4}>. This is the serialization of a body in a POST request, I have the same result when calling the API