Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring timeout durations in a custom ConnectionPool #8426

Open
lauzadis opened this issue May 28, 2024 · 0 comments
Open

Configuring timeout durations in a custom ConnectionPool #8426

lauzadis opened this issue May 28, 2024 · 0 comments
Labels
enhancement Feature not a bug

Comments

@lauzadis
Copy link

We use the public constructor of ConnectionPool to create a pool with a custom keepAliveDuration, but this does not support configuring other timeouts (like readTimeoutMillis), which are all part of the internal constructor.

This means we can't simultaneously configure connect/read/write timeouts and keepAliveDuration.

For our specific use-case, here is where we configure custom timeouts, and here is where we create a custom connection pool immediately after, effectively overriding those timeouts.

Is there some way to accomplish this already? If not, I can think of a few solutions:

  1. Add other timeout durations (like readTimeoutMillis) to the public constructor of ConnectionPool
  2. Support configuring keepAliveDuration on the default ConnectionPool without replacing it
  3. Support configuring timeout durations on an already-constructed ConnectionPool

Thanks!

@lauzadis lauzadis added the enhancement Feature not a bug label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature not a bug
Projects
None yet
Development

No branches or pull requests

1 participant