Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YML: program.build-instructions.time_limit is effectively ignored during builds #293

Open
pdreiter opened this issue Dec 8, 2021 · 0 comments

Comments

@pdreiter
Copy link
Collaborator

pdreiter commented Dec 8, 2021

Darjeeling generated a patch that did not complete the respective build, hanging the darjeeling tool during candidate patch evaluations.
You can easily duplicate this by adding an additional build command into the YML's program.build-instructions.steps like sleep X, where X>>program.build-instructions.time-limit.

During debug, I found two issues related to this:

  1. in BuildInstructions.execute
    time_left = int(max(0, time.duration - self.time_limit))
    which should be:
    time_left = int(max(0, self.time_limit - time.duration ))
    since the StopWatch/timer initial value seems to be 0.0
  2. The included DockerBlade module's shell package method check_output (dockerblade/shell.py:242) does not pass time_limit or kill_after values to the called function self.run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant