Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Bed Patch #114

Open
Mordenkainen opened this issue Feb 16, 2018 · 1 comment
Open

Conflict with Bed Patch #114

Mordenkainen opened this issue Feb 16, 2018 · 1 comment

Comments

@Mordenkainen
Copy link

Mordenkainen commented Feb 16, 2018

It appears AppleCore conflicts with BedPatch as detailed in Mordenkainen/BedPatch#2.

This seems to be the same failure as in issue #89.

Looking at the ASM patching done by both BedPatch and AppleCore I do not see any direct conflict as we are editing different classes. But it almost seems that if BedPatch patches the Chunk class, AppleCore fails to patch the EntityPlayer class. I am not sure of the exact cause of the issue.

I have found that if I change the SortingIndex of BedPatch to be after AppleCore, the issue goes away and both mods are able to make the patches they need.

I am updating Bed Patch with this change, but wanted to open an issue here so you would be aware, as this may help track down the compatibility issue in #89.

If you understand why these mods are clashing, please let me know as I would like to understand what the source of the conflict was.

@squeek502 squeek502 added the bug label Feb 16, 2018
@squeek502
Copy link
Owner

Very strange, thanks for letting me know about it. Will try to look into it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants