Crashing when paired with Oversaturation

[truenachtara]

I'm the Oversaturation dev. I'm modifying FoodStats, which is causing some players who use both this mod and my mod to crash when they eat food. However, in the dev environment, I'm experiencing a full-on crash when I load the world. Do you have any information on stopping this?

Here's my mod: https://github.com/truenachtara/Oversaturation
My dev environment crash: https://pastebin.com/Sw9XdLaC
An issue report detailing a player experiencing this issue in-game (contains crash report): Cazsius/Spice-of-Life-Carrot-Edition#32

[squeek502]

Overloading FoodStats will not be compatible with AppleCore (and with any other mods that overload FoodStats). Instead, when you detect AppleCore is installed, you should use AppleCore's events to modify the saturation like so:

@SubscribeEvent
public void getFoodValues(FoodEvent.GetPlayerFoodValues event)
{
	int maxHunger = AppleCoreAPI.accessor.getMaxHunger(event.player);
	int curHunger = event.player.getFoodStats().getFoodLevel();
	int extraSaturation = event.foodStats.hunger - (maxHunger - curHunger);
	if (extraSaturation > 0) {
		int newHunger = maxHunger - curHunger;
		float newSaturationModifier = event.foodValues.saturationModifier + extraSaturation;
		event.foodValues = new FoodValues(newHunger, newSaturationModifier);
	}
}

Note: the above should be in its own class that is only loaded when "applecore" is loaded.

See here for how to include the AppleCore API in your dev environment.

[squeek502]

Actually, I missed that your mod removes the maxSaturation == currentHunger limitation, so instead you'll need to use the method outlined here: TheRandomLabs/RandomTweaks#18