Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve libnite #27

Open
3 tasks
ipa-nhg opened this issue Mar 14, 2016 · 0 comments
Open
3 tasks

Improve libnite #27

ipa-nhg opened this issue Mar 14, 2016 · 0 comments
Assignees

Comments

@ipa-nhg
Copy link
Member

ipa-nhg commented Mar 14, 2016

  • remove the libnite2/build folder after building libnite package.

+1, the build folder should be deleted

  • The ".so" files are in devel/lib and in src/.../libnite2/common/lib. We should keep them in a single directory.

for me is ok keep them, but if you prefer delete the src/.../libnite2/common/lib/*.so after build , I have nothing against

  • Idid not understand the catkin_RUN_PACKAGES and catkin_BUILD_PACKAGES variable in libnite2/CMakeLists.txt and squirrel_person_tracker/CMakeLists.txt.
    You set the value in squirrel_person_tracker/CMakeLists.txt to:
    catkin_RUN_PACKAGES -> package_name(libnite2)
    catkin_BUILD_PACKAGES -> libnite2cmake_modules
    I don't see the purpose of this. What is libnite2cmake_modules doing anyway in find package???
    Why we don't use simple package name.

I used the variables just to test, but now, if you prefer use the package names and delete the variables, you can do it. Are not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants