Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Split pilosa driver out of go-mysql-server #463

Open
smola opened this issue Oct 17, 2018 · 3 comments
Open

Split pilosa driver out of go-mysql-server #463

smola opened this issue Oct 17, 2018 · 3 comments
Labels

Comments

@smola
Copy link
Collaborator

smola commented Oct 17, 2018

It would be good to separate the pilosa implementation to a separate library, out of go-mysql-server, in order to keep go-mysql-server as the core, free of specific implementations as much as possible.

cc @mcuadros

@smola smola added the feature label Oct 17, 2018
@kuba--
Copy link
Contributor

kuba-- commented May 24, 2019

I believe we should have more generic package like go-mysql-index which you can import like you import go's std. lib. db package and driver which will anonymously implement the Index interface, e.g.:

import (
	"github.com/src-d/go-mysql-index"
	_ "github.com/src-d/go-mysql-index/driver/pilosa"
)

@erizocosmico
Copy link
Contributor

Do we still want to do this?

@ajnavarro
Copy link
Contributor

We can leave this to see if it makes sense to do it in the future. Right now is not causing any problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants