-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a fixed version of esc #582
base: master
Are you sure you want to change the base?
Conversation
Actually we are using/going to use |
About adding it to |
if we are talking about ci I'm not sure fixed version should depend on package manager as go mod or dep. As an example, |
also CI is failing |
609d95f
to
86d68b7
Compare
Is it better to For sure, I'm open to your suggestions 👯♂️ alternative; |
Signed-off-by: David Pordomingo <[email protected]>
86d68b7
to
f92273e
Compare
I really like On another hand, I'm absolutetly okay with merging this PR if we have any problems with esc right now (I don't remember any) |
The problem we already have with Anyhow; if @carlosms also preffers to download the |
IMO if the migration to |
I don't have a strong preference here. On the other hand having a How would it look with go mod? What would it take to be able to have this in our makefile?
Something like this?
|
fix #536
In order to avoid updates in
esc
that would create different assets (what would cause our CI to reject the build), we could lock to a specific version.Since
esc
does not release frequently (its last release v0.1.0 was more than 1year ago) we need to use our own way to target a version.Alternatives:
vendor
content instead of ignoring it (doing so we'll avoid loosingesc
in case something disappears as it happened withbindata
)Gopkg.toml
andvendor
.