Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReviewEvent is_mergeable may not be reliable #560

Open
carlosms opened this issue Feb 22, 2019 · 0 comments
Open

ReviewEvent is_mergeable may not be reliable #560

carlosms opened this issue Feb 22, 2019 · 0 comments
Labels

Comments

@carlosms
Copy link
Contributor

The ReviewEvent.is_mergeable value is taken from the mergeable field of the pull request response. This field may be null while github does the mergeability test, so probably in lookout there are times where we get the event before this is true or false.

From the github docs:

The value of the mergeable attribute can be true, false, or null. If the value is null, then GitHub has started a background job to compute the mergeability. After giving the job time to complete, resubmit the request. When the job finishes, you will see a non-null value for the mergeable attribute in the response.

This issue is to discuss if we want to either remove this field from our ReviewEvent, or make it reliable waiting until github has a definitive value for the field.

@dpordomingo dpordomingo added the enhancement New feature or request label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants