From 2f46caf03bab8ba08e20f445000922aa0f22a095 Mon Sep 17 00:00:00 2001 From: Srinivas Reddy Thatiparthy Date: Wed, 5 Feb 2025 16:40:00 +0530 Subject: [PATCH] Address review comments --- Lib/test/test_traceback.py | 4 ++-- Lib/traceback.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Lib/test/test_traceback.py b/Lib/test/test_traceback.py index 48650a1b4cad10..cb91a4cdcbae7a 100644 --- a/Lib/test/test_traceback.py +++ b/Lib/test/test_traceback.py @@ -4501,8 +4501,8 @@ def __getattribute__(self, x): print(x) print(qq) - for name, instance in (("a", A()), ("b", B())): - with self.subTest(name=name): + for instance in (A(), B()): + with self.subTest(instance=instance): actual = self.get_suggestion(instance, "pop") self.assertIn("name 'qq' is not defined", actual) self.assertEqual(actual.count("NameError"), 1) diff --git a/Lib/traceback.py b/Lib/traceback.py index 3692f329921bc9..283488f9bcecd9 100644 --- a/Lib/traceback.py +++ b/Lib/traceback.py @@ -1523,7 +1523,7 @@ def _compute_suggestion_error(exc_value, tb, wrong_name): try: if hasattr(self, wrong_name): return f"self.{wrong_name}" - except Exception: + except NameError: return None try: