Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link level buoyancy should not need top-level model scope #126

Open
srmainwaring opened this issue Jan 24, 2023 · 0 comments
Open

Link level buoyancy should not need top-level model scope #126

srmainwaring opened this issue Jan 24, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@srmainwaring
Copy link
Owner

PR #65 introduced the ability to enable hydrodynamics at link level using an <enable> element.

Currently the link must be fully scoped in the namespace of the enclosing model. This limits the reusability of models containing the hydrodynamics plugin as when they are including with a <name> element, the scoped name of the link changes and the hydrodynamics is not applied.

The proposed change is to not require the immediate enclosing model's name in the scoping rules.

Examples:

  • model::float_link would be referred to as float_link
  • model::nested_model::float_link would be referred to as nested_model::float_link

where we suppose that the plugin is defined in the scope of model.

Questions:

  • Can the change be made so that is backwards compatible (or so the behaviour can be deprecated?)
@srmainwaring srmainwaring added the enhancement New feature or request label Jan 24, 2023
@srmainwaring srmainwaring self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant